Retired electronics engineer here. This product does exactly what it claims. I had corrosion problems, not odor, and after two years the tank flushed completely clear. Far better than anything else I’ve tried. I now buy them for my rental properties.